Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benhepworth as maintainer so he can review PRs #23

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

benhepworth
Copy link
Contributor

@benhepworth benhepworth commented Aug 5, 2024

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Add Ben Hepworth as codeowner and maintainer so he can review PRs. Will also need write access to the repo.

Which issue(s) this PR fixes:

Fixes #22

@benhepworth benhepworth requested a review from a team as a code owner August 5, 2024 21:15
@caubut-charter
Copy link
Contributor

@benhepworth is @RandyLevensalor's colleague. I am in favor of adding the additional code owner.

@caubut-charter caubut-charter added the subproject management Issues and PRs related to the management of the sub project label Aug 5, 2024
@hdamker
Copy link
Contributor

hdamker commented Aug 6, 2024

@camaraproject/network-access-management_maintainers please approve the PR. I'm happy to add @benhepworth then to the teams.

@hdamker hdamker self-assigned this Aug 6, 2024
@caubut-charter caubut-charter requested review from caubut-charter and a team and removed request for caubut-charter August 6, 2024 19:24
Copy link
Contributor

@caubut-charter caubut-charter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. @hdamker, CODEOWNERS does have a linting error stating @benhepworth will need to be given write access to the repo.

@hdamker
Copy link
Contributor

hdamker commented Aug 7, 2024

@benhepworth you got an invite to the CAMARA organization from GitHub ... as soon you have accepted it, you have write access and the Codeowner file gets valid.

@hdamker hdamker merged commit e39c417 into camaraproject:main Aug 7, 2024
1 check passed
@benhepworth
Copy link
Contributor Author

thanks @hdamker - I accepted the invite to the CAMARA org

@hdamker
Copy link
Contributor

hdamker commented Aug 7, 2024

I see - so we are done here.

@benhepworth benhepworth deleted the add-benhepworth-maintaner branch August 7, 2024 16:38
@benhepworth
Copy link
Contributor Author

yes, everything looks good now - thanks for your help @hdamker !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subproject management Issues and PRs related to the management of the sub project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ben Hepworth as maintaner so he can review PRs
4 participants